Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ai): trim external container docs #688

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rickstaa
Copy link
Member

This pull request makes the external container docs more concise.

This commit makes the external container docs more concise.
@rickstaa rickstaa requested a review from a team as a code owner November 15, 2024 09:58
@ad-astra-video
Copy link
Collaborator

Most of the updates look fine. Couple things to look at:

  • The capacity field updated explanation is incorrect. Setting warm: true doesn't make it fast :). Need to ensure loading of the model in the auto-scaling setup is fast!
  • Looks like the reference to (including error codes) was removed in the explanation of the container management acting as a pass through. My only concern is if the container management system returns an error that is not a known error for the pipeline it can return "normal" response in go-livepeer right? or did we fix that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants