[CIR][CIRGen][Builtin][Clang] Lowering clang::AArch64::BI__builtin_arm_ldaex #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We just went over a rebase against upstream, apologies for the churn but please update your branch for this PR and force-push! |
AmrDeveloper
force-pushed
the
lower_aarch64_3
branch
from
e1ed516 to
14a42f0
Compare
ghehg
requested changes
Jan 28, 2025
| } | ||
| StringRef intrinsicName = builtinID == clang::AArch64::BI__builtin_arm_ldrex | ||
| ? "aarch64.ldxr" | ||
| : "aarch64.ldaex"; |
There was a problem hiding this comment.
Intrinsic func name might be different. I don't think there is a llvm.aarch64.ldaex
I know it's confusing :-( , but please
See
There was a problem hiding this comment.
Hmmm interesting, i didn't realize that from quick look :D
I will update it, thank you
AmrDeveloper
force-pushed
the
lower_aarch64_3
branch
from
8b636ca to
b82a9ba
Compare
ghehg
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering clang::AArch64::BI__builtin_arm_ldaex