Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cache for EXT:crawler indexing requests #429

Conversation

kraemer-igroup
Copy link
Contributor

Fix #428 - Add EXT:crawler indexing check for htaccess, nginx and fallback middleware

@lochmueller
Copy link
Owner

Hey @kraemer-igroup
thanks for the great PR. Merged!
Regards,
Tim

@lochmueller lochmueller merged commit 945ae38 into lochmueller:main Jan 24, 2025
0 of 5 checks passed
@kraemer-igroup kraemer-igroup deleted the Disable-cache-for-EXTcrawler-indexing-requests branch January 27, 2025 08:43
@ste101
Copy link
Contributor

ste101 commented Jan 27, 2025

Would it be better to make this behavior configurable?
I'm using crawler to build up the staticfilecache.

@lochmueller
Copy link
Owner

Hey @ste101 ,
there is no need for a configuration. Without the change, EXT:crawler will geht the static files and will not trigger a recaching of the page. Only with the patch, the request will pass the htacess & Fallback middlware to trigger the regeneration.
Regards,
Tim

@kraemer-igroup
Copy link
Contributor Author

Hey @ste101, that's a good point, I did not think of this. But it still should trigger the generation of static files. This change ensures that T3Crawler does not get the cached version of the page (even if it is already cached). The downside could be that there is more server load, since already cached pages are loaded uncached via T3Crawler.

@lochmueller, you mean just not adding the .htaccess changes to avoid the (new) behaviour?

@lochmueller
Copy link
Owner

@lochmueller, you mean just not adding the .htaccess changes to avoid the (new) behaviour?

Yes. If someone do not want the behavior, keep the old htaccess and the Crawler extension will get the static files and no regeneration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable cache for EXT:crawler indexing requests
3 participants