Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AP-2596): Introduce WS room for "contentManager" #52

Closed
wants to merge 1 commit into from
Closed

feat(AP-2596): Introduce WS room for "contentManager" #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/app/websockets-common/src/rooms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const RoomSchemas = {
translation: PROJECT_ID_SCHEMA,
segment: PROJECT_ID_SCHEMA,
workspace: WORKSPACE_ID_SCHEMA,
contentManager: PROJECT_ID_SCHEMA,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kibertoad I was having a conversation with @freiondrej-lokalise regarding how we should name this one. Could you help? We were wondering whether it should be contentManager, content-manager or content_manager.

There is an example below that names one of the rooms (not used, it's just an example as far as I see) project-user. On the other hand, we already have some WS event names like git.file_download_failed so maybe we should follow the same approach and also name WS rooms with _ in between. What are your thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no strong opinion on this. converging on smaller amount of universal conventions is always nice, but we need approval from all teams to change conventions

user: USER_ID_SCHEMA,
// Unused room - this is an example how to use room with multiple parameters.
'project-user': PROJECT_USER_ID_SCHEMA,
Expand Down
Loading