Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OneChat notification provider #5546

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

xNewz
Copy link

@xNewz xNewz commented Jan 17, 2025

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This PR adds a new Notification Provider for OneChat, allowing users to receive alerts and notifications directly via OneChat.
Fixes #(issue)

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Event Image
UP UP
DOWN DOWN
Certificate-expiry Certificate-expiry
Testing Testing

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. There are a few changes I'd like to see before we can merge this in v2.1

server/notification-providers/onechat.js Show resolved Hide resolved
server/notification-providers/onechat.js Outdated Show resolved Hide resolved
server/notification-providers/onechat.js Outdated Show resolved Hide resolved
server/notification-providers/onechat.js Outdated Show resolved Hide resolved
server/notification-providers/onechat.js Outdated Show resolved Hide resolved
src/components/notifications/OneChat.vue Outdated Show resolved Hide resolved
src/components/notifications/OneChat.vue Outdated Show resolved Hide resolved
@CommanderStorm CommanderStorm added pr:please address review comments this PR needs a bit more work to be mergable area:notifications Everything related to notifications labels Jan 24, 2025
@xNewz xNewz requested a review from CommanderStorm January 25, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications pr:please address review comments this PR needs a bit more work to be mergable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants