Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new page on writing JSON BLOCK files. #23

Merged
merged 4 commits into from
May 3, 2024
Merged

Conversation

edennihy
Copy link
Contributor

No description provided.

@edennihy edennihy requested a review from tribeiro April 29, 2024 18:37
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I would just suggest you change how people should install the package to use conda instead of clone/pip install. Also, we should add this package to the nublado images. I will make sure this is done on the current revision.

The `ts observing`_ repository can be installed in your local environment by running

.. prompt:: bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best way to install this package is actually to use conda. This packages has some dependencies that are not pulled when installed this way. This is how one would install the package for development.

Also, we should probably add this to the nublado images.

I would recommend replacing it with something like this:

conda install -c lsstts -y ts-observing

@edennihy edennihy force-pushed the tickets/DM-40173 branch from 375653f to b35de65 Compare May 2, 2024 23:11
@edennihy edennihy merged commit 7811ddb into main May 3, 2024
1 check passed
@edennihy edennihy deleted the tickets/DM-40173 branch May 3, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants