Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement skeleton codes in server/push #539

Merged
merged 2 commits into from
Nov 22, 2017
Merged

Implement skeleton codes in server/push #539

merged 2 commits into from
Nov 22, 2017

Conversation

GarlicB
Copy link
Contributor

@GarlicB GarlicB commented Nov 19, 2017 •
edited by romandev
Loading

To avoid conflict, updated the skeleton codes again at the most recent
commit phase.

ISSUE=#500

@GarlicB
Copy link
Contributor Author

GarlicB commented Nov 20, 2017

oops, soon i’ll fix lint err

@nadongguri
Copy link
Collaborator

Minor one, would you change the position of the sentences? The description should be first then ISSUE line follows. :)

@GarlicB
Copy link
Contributor Author

GarlicB commented Nov 21, 2017

@nadongguri, OK. i changed the position

romandev
romandev approved these changes Nov 22, 2017
View reviewed changes
Copy link
Member

@romandev romandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@romandev romandev merged commit 966ad77 into lunchclass:master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romandev romandev romandev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GarlicB @nadongguri @romandev