Skip to content

Commit

Permalink
Refactor mantis-publish-core 3rd party dependency specifications
Browse files Browse the repository at this point in the history
first pass at refactor 3rd party dependency specifications for mantis-publish-core and corresponding changes to root build.gradle. Name changes to make version vars consistent. (issue Netflix#345)
  • Loading branch information
mabelbot committed Mar 2, 2023
1 parent 34a352e commit 4926b28
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 16 deletions.
5 changes: 3 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ ext.versions = [
junit5 : "5.4.+",
kafkaVersion : "2.2.+",
mesosVersion : '1.7.2',
mockito : "2.0.+",
mockito : "2.18.+",
mockito3 : "3.+",
mqlVersion : '3.4.+',
nettyVersion : "4.1.34.Final",
Expand Down Expand Up @@ -141,7 +141,8 @@ ext.libraries = [
slf4jLog4j12 : "org.slf4j:slf4j-log4j12:${versions.slf4j}",
snappyJava : "org.xerial.snappy:snappy-java:${versions.snappyVersion}",
spectatorApi : "com.netflix.spectator:spectator-api:${versions.spectator}",
spectatorApiv0 : "com.netflix.spectator:spectator-api:0.82.+",
spectatorApi0 : "com.netflix.spectator:spectator-api:0.134.0",
spectatorExtIpc0: "com.netflix.spectator:spectator-ext-ipc:0.134.0",
spotifyFutures : "com.spotify:completable-futures:0.3.1",
testng : "org.testng:testng:${versions.testngVersion}",
vavr : "io.vavr:vavr:${versions.vavr}",
Expand Down
2 changes: 1 addition & 1 deletion mantis-connectors/mantis-connector-kafka/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ dependencies {
api libraries.kafkaClients

api libraries.rxJava
api libraries.spectatorApiv0
api libraries.spectatorApi0
api libraries.archaius2Api
api libraries.archaius2Core

Expand Down
20 changes: 7 additions & 13 deletions mantis-publish/mantis-publish-core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,20 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
ext {
archaiusVersion = 'latest.release'
versionMockito = '2.18.+'
mqlVersion = '3.2.2' // todo: builds correctly, bump version later
spectatorVersion = '0.134.0'
}

dependencies {
implementation "io.mantisrx:mql-jvm:$mqlVersion"
implementation libraries.mqlJvm
implementation project(":mantis-common-serde")
api project(":mantis-discovery-proto")

api "com.netflix.spectator:spectator-api:$spectatorVersion"
implementation "com.netflix.spectator:spectator-ext-ipc:$spectatorVersion"
api libraries.spectatorApi0
implementation libraries.spectatorExtIpc0

api "com.netflix.archaius:archaius2-api:$archaiusVersion"
implementation "com.netflix.archaius:archaius2-core:$archaiusVersion"
api libraries.archaius2Api
implementation libraries.archaius2Core

testImplementation "com.github.tomakehurst:wiremock-jre8:2.21.0"
testCompileOnly "com.netflix.archaius:archaius2-core:$archaiusVersion"
testImplementation libraries.wiremock
testCompileOnly libraries.archaius2Core

implementation libraries.slf4jApi

Expand Down

0 comments on commit 4926b28

Please sign in to comment.