Refactor mantis-examples-mantis-publish-web-sample 3rd party dependen…

…cy specifications first pass at refactor 3rd party dependency specifications for mantis-examples-mantis-publish-web-sample and corresponding changes to root build.gradle (issue Netflix#345)
mabelbot · Mar 2, 2023 · d90bad4 · d90bad4
1 parent bc0ad96
commit d90bad4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 15 deletions.
diff --git a/build.gradle b/build.gradle
@@ -48,6 +48,7 @@ ext.versions = [
         guavaFailureAccessVersion : '1.0.1',
         guavaVersion : '31.1-jre',
         guiceVersion : "4.2.2",
+        guiceServletVersion : '4.0',
         hadoop   : "2.7.7",
         hdrHistogramVersion : '2.+',
         httpComponentsVersion : '4.5.6',
@@ -123,10 +124,11 @@ ext.libraries = [
         gson           : "com.google.code.gson:gson:${versions.gsonVersion}",
         guava          : "com.google.guava:guava:${versions.guavaVersion}",
         guice          : "com.google.inject:guice:${versions.guiceVersion}",
+        guiceServlet   : "com.google.inject.extensions:guice-servlet:${versions.guiceServletVersion}",
         hadoopCommon   : "org.apache.hadoop:hadoop-common:${versions.hadoop}",
         hadoopS3       : "org.apache.hadoop:hadoop-aws:${versions.hadoop}",
         hamcrest       : "org.hamcrest:hamcrest-core:1.3",
-        hamcrestAll    : 'org.hamcrest:hamcrest-all:1.3',
+        hamcrestAll    : "org.hamcrest:hamcrest-all:1.3",
         hdrHistogram   : "org.hdrhistogram:HdrHistogram:${versions.hdrHistogramVersion}",
         httpClient     : "org.apache.httpcomponents:httpclient:${versions.httpComponentsVersion}",
         iceberg        : [
@@ -144,6 +146,7 @@ ext.libraries = [
         jacksonDatatypeJsr310 : "com.fasterxml.jackson.datatype:jackson-datatype-jsr310:${versions.jacksonVersion}",
         jacksonModuleAfterburner : "com.fasterxml.jackson.module:jackson-module-afterburner:${versions.jacksonVersion}",
         jacksonDataformatCbor :  "com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:${versions.jacksonVersion}",
+        javaxServletApi: "javax.servlet:javax.servlet-api:3.1.0",
         jcip           : "net.jcip:jcip-annotations:1.0",
         jctools        : "org.jctools:jctools-core:${versions.jctoolsVersion}",
         jline          : "jline:jline:${versions.jlineVersion}",

diff --git a/mantis-examples/mantis-examples-mantis-publish-web-sample/build.gradle b/mantis-examples/mantis-examples-mantis-publish-web-sample/build.gradle
@@ -30,25 +30,18 @@ plugins {
 }
 
 
-ext {
-
-    guiceVersion = '4.2.2'
-    spectatorVersion = '0.96.0'
-    archaiusVersion = 'latest.release'
-    guiceServletVersion = '4.0'
-}
 
 
 dependencies {
     compile project(":mantis-publish:mantis-publish-netty-guice")
 
-    providedCompile 'javax.servlet:javax.servlet-api:3.1.0'
-    implementation "com.netflix.spectator:spectator-ext-ipc:$spectatorVersion"
-    implementation "com.netflix.archaius:archaius2-core:$archaiusVersion"
-    implementation "com.netflix.archaius:archaius2-guice:$archaiusVersion"
-    implementation "com.google.inject:guice:$guiceVersion"
-    implementation "com.netflix.spectator:spectator-nflx-plugin:$spectatorVersion"
+    providedCompile libraries.javaxServletApi
+    implementation libraries.spectatorExtIpc0
+    implementation libraries.archaius2Core
+    implementation libraries.archaius2Guice
+    implementation libraries.guice
+    implementation libraries.spectatorPlugin0
     implementation libraries.slf4jLog4j12
 
-    compile 'com.google.inject.extensions:guice-servlet:4.0'
+    compile libraries.guiceServlet
 }