Refactor mantis-connector-job 3rd party dependency specifications

first pass at refactor 3rd party dependency specifications for mantis-connector-job and corresponding changes to root build.gradle (issue Netflix#345)
mabelbot · Mar 1, 2023 · fce4d3d · fce4d3d
1 parent 2d27da4
commit fce4d3d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/build.gradle b/build.gradle
@@ -37,6 +37,7 @@ buildscript {
 ext.versions = [
         avroVersion : "1.10.2",
         flink    : "1.14.2",
+        gsonVersion : "2.8.+",
         hadoop   : "2.7.7",
         icebergVersion : "0.14.+",
         jctoolsVersion : "1.+",
@@ -68,6 +69,7 @@ ext.libraries = [
                 "junit:junit:${versions.junit4}",
                 "junit:junit-dep:${versions.junit4}",
         ],
+        gson           : "com.google.code.gson:gson:${versions.gsonVersion}",
         hadoopCommon   : "org.apache.hadoop:hadoop-common:${versions.hadoop}",
         hadoopS3       : "org.apache.hadoop:hadoop-aws:${versions.hadoop}",
         hamcrest       : "org.hamcrest:hamcrest-core:1.3",

diff --git a/mantis-connectors/mantis-connector-job/build.gradle b/mantis-connectors/mantis-connector-job/build.gradle
@@ -16,16 +16,13 @@
 
 apply plugin: 'mantis'
 
-ext {
-    gsonVersion = '2.8.+'
-}
 
 dependencies {
     implementation project(":mantis-runtime")
     implementation project(":mantis-client")
     implementation project(":mantis-control-plane:mantis-control-plane-core")
     implementation project(":mantis-publish:mantis-publish-core")
 
-    implementation "com.google.code.gson:gson:$gsonVersion"
+    implementation libraries.gson
     implementation libraries.vavr
 }