Gawain Hewitt's Airport Weekend Challenge, week 1 #2508
Conversation
…to show that I got to the end of story 3 this way before I start again
There was a problem hiding this comment.
A good interpretation of Airport Challenge, well done.
You successfully met the specification of each user story, bar Weather, with some good examples of unit testing.
There was separation of concerns between Plane and Airport as objects.
With weather, it appears that the only circumstance in which the weather will be stormy is in your tests - can you think of a way of randomising the weather conditions, so that sometimes it will be stormy, and sometimes sunny?
| @@ -0,0 +1,17 @@ | |||
| class Airport | |||
| attr_writer :capacity | |||
| DEFAULT_CAPACITY = 20 | |||
There was a problem hiding this comment.
I'd leave an empty line between attr_readers, constant variables and the first method definition for readability
| end | ||
|
|
||
| def plane_take_off | ||
| @hangar_log -= 1 |
There was a problem hiding this comment.
What would happen if this method was run when no planes had ever landed?
| def land(airport) | ||
| fail "plane already landed" if @landed | ||
| fail "landing is prevented in stormy weather" if @weather == :stormy | ||
| @landed = airport |
There was a problem hiding this comment.
'landed' as a variable description doesn't necessarily match up with airport as a value (in terms of its naming), when landed is a boolean value
| it 'prevents landing when full' do | ||
| 20.times do | ||
| plane = Plane.new | ||
| planes << plane |
There was a problem hiding this comment.
You don't use the planes variable again after this - is it needed?
| let(:ibiza) { Airport.new } | ||
| let(:new_york) { Airport.new } | ||
|
|
||
| let(:eoins_private_jet) { Plane.new } |
Gawain Hewitt
Please write your full name here to make it easier to find your pull request.
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!