Revert lower baselines for the heatmaps in WebGL2 Firefox #12734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepankuzmin
added
the
skip changelog
stepankuzmin
commented
May 31, 2023
| @@ -123,9 +123,10 @@ function bindTextureToFramebuffer(context: Context, painter: Painter, texture: ? | |||
| // Use the higher precision half-float texture where available (producing much smoother looking heatmaps); | |||
| // Otherwise, fall back to a low precision texture | |||
| /* $FlowFixMe[prop-missing] WebGL2 */ | |||
| const type = context.extRenderToTextureHalfFloat ? (context.isWebGL2 ? gl.HALF_FLOAT : context.extTextureHalfFloat.HALF_FLOAT_OES) : gl.UNSIGNED_BYTE; | |||
There was a problem hiding this comment.
Heatmaps work with this fix now with WebGL2, but I'm unsure about removing the gl.getExtension('EXT_color_buffer_half_float') check here. /cc @astojilj
There was a problem hiding this comment.
Unfortunately, this might break some Android GPUs that don't support EXT_color_buffer_half_float. So we're still blocked by Firefox not supporting EXT_color_buffer_half_float in WebGL 2.0 contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert lower baselines for the heatmaps in WebGL2 Firefox from #12701
Launch Checklist
mapbox-gl-jschangelog:<changelog></changelog>