Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate tile reloading logic from RasterSource in CustomSource #12993

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Duplicate tile reloading logic from RasterSource in CustomSource #12993

merged 1 commit into from
Dec 4, 2023

Conversation

stepankuzmin
Copy link
Contributor

@stepankuzmin stepankuzmin commented Dec 1, 2023 •
edited
Loading

Duplicate tile reloading logic from RasterSource in CustomSource. This PR should target #12924, but since it's a remote fork, we can merge it after #12924 lands.

Changes for review 17311f9

Launch Checklist

  • Make sure the PR title is descriptive and preferably reflects the change from the user's perspective.
  • Manually test the debug page.

@stepankuzmin stepankuzmin requested a review from a team as a code owner December 1, 2023 12:38
@stepankuzmin stepankuzmin mentioned this pull request Dec 1, 2023
Merged
5 tasks
@mourner mourner changed the base branch from main to pathological-flyto-memory December 1, 2023 14:12
mourner
mourner approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a local branch with the other PR just to see the changes, but feel free to switch it back to main after #12924 is merged.

@stepankuzmin stepankuzmin changed the base branch from pathological-flyto-memory to main December 4, 2023 09:32
@stepankuzmin stepankuzmin force-pushed the custom-source-duplicate-tile-unloading-logic branch from 17311f9 to 833d170 Compare December 4, 2023 09:36
@stepankuzmin stepankuzmin merged commit d7aeb4b into main Dec 4, 2023
28 checks passed
@stepankuzmin stepankuzmin deleted the custom-source-duplicate-tile-unloading-logic branch December 4, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepankuzmin @mourner