This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Introduce descender, ascender in glyphMetrics + Fix fonts dis-alignment #15676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
zmiao
force-pushed
the
zmiao-fix-mixed-fonts-disalignment
branch
from
a7309a5
to
21e65d7
Compare
zmiao
force-pushed
the
zmiao-fix-mixed-fonts-disalignment
branch
from
0808ad6
to
bae131e
Compare
pozdnyakov
reviewed
Sep 26, 2019
zmiao
force-pushed
the
zmiao-fix-mixed-fonts-disalignment
branch
from
bae131e
to
70942a2
Compare
zmiao
force-pushed
the
zmiao-fix-mixed-fonts-disalignment
branch
3 times, most recently
from
7a8a714
to
32dd8e6
Compare
zmiao
force-pushed
the
zmiao-fix-mixed-fonts-disalignment
branch
from
dce9656
to
20f73e7
Compare
…aking existed render tests
zmiao
force-pushed
the
zmiao-fix-mixed-fonts-disalignment
branch
from
20f73e7
to
da7a67b
Compare
chloekraw
added
the
⚠️ DO NOT MERGE
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapbox/node-fontnik#160 will introduce new metadata
ascenderanddescender, it would help fix issue mapbox/mapbox-gl-js#191. This pr only covers reading data from pbf and partially replacing hard coded baseline for fixing mixed fonts dis-alignment.Render test: mapbox/mapbox-gl-js#8781