-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SSDK-736] fix SDK import through SPM #213
Conversation
|
||
/// https://forums.swift.org/t/update-on-implementation-only-imports/26996 | ||
@_implementationOnly import MapboxCoreSearch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes me think, @ _implementationOnly
isn't the only experimental attribute we use, there is also @_exported
: https://github.com/search?q=repo:mapbox/mapbox-search-ios%20_exported&type=code
Dropping it would be a breaking change because all developers will have to add additional imports, so I guess we can leave it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that @_exported inside MapboxSearchController is very convenient to automatically import MapboxSearch. Stay tuned as the language evolves.
…736-address-autofill-fixes
Description
Fixes SSDK-736
Checklist
CHANGELOG