Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ellipsis] Fix Model Identifier and Syntax in Azure Chat Route #1762

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ellipsis-dev[bot]
Copy link

@ellipsis-dev ellipsis-dev bot commented May 28, 2024

This change addresses review comments left by @1orZero on PR #1755: Add GPT-4o for Azure OpenAI

⚠️ We couldn't build/test your project to verify our changes. Add a Dockerfile to significantly improve code quality.

Summary:

Updated the model identifier for better accuracy in deployment ID fetching and added a missing closing brace in app/api/chat/azure/route.ts.

Key points:

  • Corrected model identifier from "gpt-4o" to "gpt-4-o" in app/api/chat/azure/route.ts.
  • Added a closing brace at the end of the file.

You can configure Ellipsis to address comments with a direct commit or a side PR, see docs.


Something look wrong?: If this Pull Request doesn't address the comments left on the above pull request, create a new PR review with more details. For more information, check the documentation.

Generated with ❤️ by ellipsis.dev

@nsbradford
Copy link

nsbradford commented May 28, 2024

hi from Ellipsis team - this was a response to this comment: #1755 (comment), but making PRs for forks isn't fully supported due to API limitations - more explicit messaging coming soon 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants