Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipe management to Node SDK #1289

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

giraffekey
Copy link
Contributor


name: Add pipe management to Node SDK
about: Add pipes functions
title: "Add pipe management to Node SDK"
labels: ''
assignees: ''


description

Adds the following functions to the Node SDK:

  • pipe.pipes.list()
  • pipe.pipes.download()
  • pipe.pipes.enable()
  • pipe.pipes.disable()
  • pipe.pipes.update()

related issue: #1283

how to test

add a few steps to test the pr in the most time efficient way.

  1. Run screenpipe server at localhost:3030
  2. Instantiate NodePipe class
  3. Run all functions in .pipes

/claim #1283

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 4:18am

@louis030195
Copy link
Collaborator

louis030195 commented Feb 7, 2025

it should also be available in browser sdk i guess?

@giraffekey
Copy link
Contributor Author

it should also be available in browser sdk i guess?

Done.

@giraffekey
Copy link
Contributor Author

The browser SDK ended up with additional changes to the code because I ran prettier on it.

@tribhuwan-kumar
Copy link
Contributor

@giraffekey

what you're doing is already done #1295
you can close it now!!

@louis030195
Copy link
Collaborator

/approve

thx!

@tribhuwan-kumar @giraffekey was first BTW

Copy link

algora-pbc bot commented Feb 7, 2025

@louis030195: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

@louis030195 louis030195 merged commit d9b2e56 into mediar-ai:main Feb 7, 2025
2 checks passed
@tribhuwan-kumar
Copy link
Contributor

tribhuwan-kumar commented Feb 7, 2025

after my pr he found out his mistakes, also this pr doesn't even covers all the methods of pipe management. there are silly type defined, that'd just make harder to debug. its not about who did it first its about the who did it better. if I didn't reviewed this pr then you'd be still finding those errors. he wasn't not even tested before pushing the code.

@louis030195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants