-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pipe management to Node SDK #1289
Add pipe management to Node SDK #1289
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
it should also be available in browser sdk i guess? |
Done. |
The browser SDK ended up with additional changes to the code because I ran prettier on it. |
what you're doing is already done #1295 |
/approve thx! @tribhuwan-kumar @giraffekey was first BTW |
@louis030195: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment. |
after my pr he found out his mistakes, also this pr doesn't even covers all the methods of pipe management. there are silly type defined, that'd just make harder to debug. its not about who did it first its about the who did it better. if I didn't reviewed this pr then you'd be still finding those errors. he wasn't not even tested before pushing the code. |
name: Add pipe management to Node SDK
about: Add pipes functions
title: "Add pipe management to Node SDK"
labels: ''
assignees: ''
description
Adds the following functions to the Node SDK:
related issue: #1283
how to test
add a few steps to test the pr in the most time efficient way.
.pipes
/claim #1283