Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: snapshots after removing embedders from default settings #1627

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: snapshots after removing embedders from default settings #1627

merged 1 commit into from
Jan 15, 2024

Conversation

mdubus
Copy link
Member

@mdubus mdubus commented Jan 15, 2024

Pull Request

What does this PR do?

Update snapshots which were failing after embedders were removed from the settings by default

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@mdubus mdubus added the maintenance Issue about maintenance (CI, tests, refacto...) label Jan 15, 2024
@curquiza curquiza merged commit 53ef480 into bump-meilisearch-v1.6.0 Jan 15, 2024
4 of 7 checks passed
@curquiza curquiza deleted the fix_snapshots_remove_embedders_from_settings branch January 15, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdubus @curquiza