-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new index settings to configure prefixSearch
and facetSearch
#1790
Conversation
5e69ba6
to
3c2a2b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably want to update the Readme to add those new settings as well 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review! I looked into your comments and answered your feedback.
Updated the README as well. I think this is good now 🤞 |
Can you update it to add the |
I did, sorry for the inattention mistake 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨🦕 🌻
prefixSearch
and facetSearch
index settingsprefixSearch
and facetSearch
1797: Update version for the next release (v0.47.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-js to a new version: "v0.47.0" CHANGELOGS 👇 This version introduces features released on Meilisearch v1.12.0 🎉 Check out the [Meilisearch v1.12.0 changelog](https://github.com/meilisearch/meilisearch/releases/tag/v1.12.0) for more information. ## 🚀 Enhancements - **Addition:** #1775 Introducing new methods to get one or several batches, respectively `getBatch()` and `getBatches()`. ```ts // fetch one batch using batch UID const batch = await client.getBatch(123) // fetch all batches const batches = await client.getBatches() ``` - **Addition:** #1774 The `getTasks()` methods now accept a `reverse` parameter to retrieve tasks in reverse chronological order. ```ts const tasks = await client.getTasks({ reverse: true }); ``` - **Addition:** #1790 Index settings now allow disabling **prefix search** and **facet search**. They're both enabled by default. The SDK now comes with dedicated methods to configure these settings. ```ts // disable prefix search await client.index('myIndex').updatePrefixSearch('disabled') // reset prefix search settings await client.index('myIndex').resetPrefixSearch() // disable facet search await client.index('myIndex').updateFacetSearch(false) // reset facet search settings await client.index('myIndex').resetFacetSearch() ``` - **Update:** #1773 The `_matchesPosition` array now contains an `indices` array the text was matched in an array. When searching for `fantasy` in a document that has a searchable `genre` field with the value `genre: ["fantasy", "adventure"]`, the matches position will be as follow: ```ts { genre: [{ start: 0, length: 7, indices: [0] }] } ``` Which means: - There was a single match in the `genre` array (array length == 1) - The match started as position `0` (the first character, "f") - The match has a length of `7` (the entire "fantasy" word) - The match was in the first item of the array (indices == [0]) ⚙️ Maintenance/misc - Update CONTRIBUTING.md with minimal Node version (#1788) Thanks again to `@/irevoire,` `@/Barabasbalazs,` `@/irevoire,` `@/curquiza,` and `@/Strift.` 🎉 Co-authored-by: meili-bot <[email protected]>
Pull Request
Related issue
Fixes #1770
What does this PR do?
Settings
type so the methods getSettings(), and updateSettings can accept the new settings fields: facetSearch & prefixSearchgetFacetSearch()
,updateFacetSearch()
, andresetFacetSearch()
getPrefixSearch()
,updatePrefixSearch()
, andresetPrefixSearch()
calling the appropriate Meilisearch routes