Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for updating package version #1794

Closed
wants to merge 3 commits into from

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Dec 4, 2024

Pull Request

What does this PR do?

  • adds a script which assists in updating the version of this package
  • the command is yarn update-version
  • arguments are one of
    • -p (or --patch or no arguments) - bumps the patch version (0.46.0 -> 0.46.1)
    • -m (or --minor) - bumps the minor version (0.46.0 -> 0.47.0)
    • -M (or --major) - bumps the major version (0.46.0 -> 1.0.0)
    • -e (or --exact) - changes the version to exactly what you specify as X.X.X

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@flevi29 flevi29 added enhancement New feature or request maintenance Issue about maintenance (CI, tests, refacto...) labels Dec 4, 2024
@flevi29 flevi29 requested a review from curquiza December 4, 2024 09:51
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (756d856) to head (f6943f3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1794   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          17       17           
  Lines        1465     1465           
  Branches      307      307           
=======================================
  Hits         1433     1433           
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flevi29
Copy link
Collaborator Author

flevi29 commented Dec 4, 2024

Or would you prefer changeset, like in meilisearch-js-plugins?

@flevi29
Copy link
Collaborator Author

flevi29 commented Dec 10, 2024

I can see that there's an automatic script that already makes a PR for this. How does it work?
#1797
Couldn't figure out how the bot knows what to update.

@flevi29 flevi29 marked this pull request as draft December 10, 2024 16:04
@flevi29 flevi29 removed the enhancement New feature or request label Dec 10, 2024
@Strift
Copy link
Collaborator

Strift commented Dec 11, 2024

Hey @flevi29, thanks for your contribution.

The automation used for creating the PR you mentioned lives in a private repository. It's a bit old, but it's working for now, so I think @curquiza prefers not to touch it for now.

@flevi29
Copy link
Collaborator Author

flevi29 commented Dec 11, 2024

@Strift Ah okay, I made this PR because CONTRIBUTING.md states that the version is updated manually. If #1792 ever becomes a reality, this private repository you mentioned will have to be updated. Unless JSR starts supporting package.json, which honestly they should (just opened an issue, let's see their reasoning jsr-io/jsr#864), but it's not a big deal to update an additional JSON file.

I guess I'm closing this then.

@flevi29 flevi29 closed this Dec 11, 2024
@curquiza
Copy link
Member

@flevi29 yes so far, the automation is private

However, I would be ok to add an automation here, but only as a github action (with workflow dispatch`). I don't want we need to go in the terminal and run a script to do it. Everything in the GitHub interface will be better 😉

@flevi29
Copy link
Collaborator Author

flevi29 commented Dec 11, 2024

Alright, I'll think about it that way. 👍

@flevi29 flevi29 deleted the update-version-script branch January 28, 2025 10:00
@flevi29
Copy link
Collaborator Author

flevi29 commented Jan 29, 2025

Hey @curquiza, I see these types of PRs: #1830

What is the trigger for them? They can't be automatic, right? They have to be manually run workflows, right?

Also I somehow need to get the version from release drafter? How does the current implementation solve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants