-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve playgrounds #1839
Improve playgrounds #1839
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1839 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 17 17
Lines 1565 1565
Branches 338 338
=======================================
Hits 1547 1547
Misses 18 18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @flevi29, thanks for the PR.
Can you add the following files, please?
package.json
with the following scripts:
"dev": "vite",
"build": "vite build",
"preview": "vite preview"
README.md
with the initial Vite instructions
Whoops, forgot to add the script. I'm keeping the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's best for the playgrounds to be as beginner-friendly as possible. In that regard, we want them to be pretty much copy-pastable, as is.
So we want the playground/javascript
to look like a real Vite project. This needs to include:
- a minimal
README.md
(to explain how to install deps & run dev server) - a minimal
package.json
so they can install deps &npm run dev
The rest is good for me. 👌
…js into improve-playgrounds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Pull Request
What does this PR do?
package.json
Vite dependency, modernize it according to https://vite.new/vanillaPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!