Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test latest major Node.js LTS version #1840

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Jan 27, 2025

Pull Request

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@flevi29 flevi29 added the maintenance Issue about maintenance (CI, tests, refacto...) label Jan 27, 2025
@flevi29 flevi29 requested a review from Strift January 27, 2025 08:49
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (009580f) to head (fa86746).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1840      +/-   ##
==========================================
+ Coverage   98.21%   98.84%   +0.63%     
==========================================
  Files          17       17              
  Lines        1565     1565              
  Branches      333      338       +5     
==========================================
+ Hits         1537     1547      +10     
+ Misses         28       18      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@flevi29
Copy link
Collaborator Author

flevi29 commented Jan 27, 2025

I think the bot is having issues with bors.toml suddenly changing.

@flevi29 flevi29 requested a review from curquiza January 28, 2025 07:50
@curquiza curquiza merged commit 7b6698f into meilisearch:main Jan 28, 2025
7 of 8 checks passed
@flevi29 flevi29 deleted the test-all-maintenance-lts-node-js branch January 28, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants