Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vectorStore experimental settings #1845

Closed

Conversation

Strift
Copy link
Collaborator

@Strift Strift commented Jan 29, 2025

Pull Request

Related issue

Fixes #1844

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Strift Strift added the enhancement New feature or request label Jan 29, 2025
@Strift Strift force-pushed the feat/remove-vector-store-experimental branch from 5be626c to 5d914a2 Compare January 29, 2025 10:16
@Strift
Copy link
Collaborator Author

Strift commented Jan 29, 2025

Hi @curquiza, everything seems to work but I have a bunch of commits that shouldn't be part of the PR.

These commits are from the main branch. I rebased on bump-meilisearch-v1.13 but they're still here. 🤔

I'm not sure how I should approach this

@flevi29
Copy link
Collaborator

flevi29 commented Jan 29, 2025

There's this git rebase --onto thing, but I am really confused as to how does it work.

I'd personally just re-create the PR with bump-meilisearch-v1.13 as the base branch.

@curquiza
Copy link
Member

curquiza commented Jan 29, 2025

Yes indeed, that's super weird
If the rebase does not work, I would go with re-creating the PR, but normally the rebase should work

git checkout bump-meilisearch-v1.13
git pull origin bump-meilisearch-v1.13
git checkout feat/remove-vector-store-experimental
git pull origin feat/remove-vector-store-experimental
git rebase bump-meilisearch-v1.13
git push --force-with-lease origin feat/remove-vector-store-experimental

⚠️ It's important to precise rebase bump-meilisearch-v1.13 and not rebase alone because otherwise your git command can interpret as git rebase main

@Strift
Copy link
Collaborator Author

Strift commented Jan 30, 2025

Replaced by #1846

@Strift Strift closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants