Skip to content

Commit

Permalink
Merge #1002
Browse files Browse the repository at this point in the history
1002: Fix typos r=Strift a=davidwebster48

# Pull Request

## Related issue
N/A

## What does this PR do?
- Fixes typos

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [ ] Have you read the contributing guidelines?
- [ ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: David Webster <>
  • Loading branch information
meili-bors[bot] authored Jan 30, 2025
2 parents a03adca + 9596bdd commit be6ff95
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ GitHub Actions will be triggered and push the beta version to [npm](https://www.
- merge the change into `bump-meilisearch-v*.*.*`
- rebase the `vX.X.X-beta.0` branch
- change the version name in `package.json`
- creata a pre-release via the GitHub interface
- create a pre-release via the GitHub interface

<hr>

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ For example, given two content-types:

The index `product` has both the entries of shoes and shirts. If the index `product` has `350` documents in Meilisearch, it is not possible to know how many of them are from `shoes` or `shirts`.

When removing `shoes` or `shirts` from Meilisearch, both are removed as it would require to much processing to only remove one. You can still re-index only one after that.
When removing `shoes` or `shirts` from Meilisearch, both are removed as it would require too much processing to only remove one. You can still re-index only one after that.

<p align="center">Example with two single types:</p>
<p align="center">
Expand Down Expand Up @@ -652,5 +652,5 @@ If you want to know more about the development workflow or want to contribute, p
Using the [foodadvisor](https://github.com/strapi/foodadvisor) restaurant demo Strapi provided. We added a searchbar to it using [instant-meilisearch](https://github.com/meilisearch/meilisearch-js-plugins/tree/main/packages/instant-meilisearch).

<p align="center">
<img src="./assets/restaurant.gif" alt="Fooradvisor demo" width="600"/>
<img src="./assets/restaurant.gif" alt="Foodadvisor demo" width="600"/>
</p>
4 changes: 2 additions & 2 deletions admin/src/Hooks/useAlert.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ export function useAlert() {
/**
* @param {object} options
* @param {string} [options.type='info']
* @param {string} [options.message='SomethingoccuredinMeilisearch']
* @param {string} [options.message='SomethingoccurredinMeilisearch']
* @param {object} [options.link]
* @param {boolean} [options.blockTransition]
*/
function handleNotification({
type = 'info',
message = i18n(
'plugin.message.something',
'Something occured in Meilisearch',
'Something occurred in Meilisearch',
),
link,
blockTransition = true,
Expand Down
2 changes: 1 addition & 1 deletion admin/src/containers/Settings/PluginActions.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const PluginActions = () => {
</Box>
<Box paddingTop={0} paddingLeft={2} paddingRight={2} paddingBottom={2}>
<Typography variant="omega" textColor="neutral800">
Applies the same cleaning as when you remove the plugin. Additionnaly,
Applies the same cleaning as when you remove the plugin. Additionally,
it also uninstalls the plugin.
</Typography>
</Box>
Expand Down
2 changes: 1 addition & 1 deletion admin/src/translations/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"plugin.message.success.add": "Request to add a content-type is successful",
"plugin.message.success.update": "Request to update content-type is successful",
"plugin.message.success.credentials": "Credentials successfully updated!",
"plugin.message.something": "Something occured in Meilisearch",
"plugin.message.something": "Something occurred in Meilisearch",
"plugin.message.forbidden.title": "Forbidden",
"plugin.message.forbidden.description": "You do not have permission to do this action"
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
* }
*
* Since Meilisearch is expecting `category: ["Italian", "french"]` and
* also `category` to be in `filterableAttributes` we can use the model configuration file to provide all these informations.
* also `category` to be in `filterableAttributes` we can use the model configuration file to provide all this information.
*/

module.exports = {
Expand Down
6 changes: 3 additions & 3 deletions server/src/config/configuration-validation.js
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ function EntriesQuery({ configuration, collectionName }) {
},

validateLocale() {
// locale is either undefined or a none empty string
// locale is either undefined or a non-empty string
if (
(locale !== undefined && typeof locale !== 'string') ||
locale === ''
Expand Down Expand Up @@ -321,7 +321,7 @@ function PluginConfig({ configuration }) {
},

validateHost() {
// apiKey is either undefined or a none empty string
// host is either undefined or a non-empty string
if ((host !== undefined && typeof host !== 'string') || host === '') {
log.error('The "host" option should be a non-empty string')
} else if (host !== undefined) {
Expand All @@ -331,7 +331,7 @@ function PluginConfig({ configuration }) {
},

validateCollections() {
// Itterate over all collections to validate their configuration
// Iterate over all collections to validate their configuration
for (const collection in collections) {
if (!isObject(collections[collection])) {
log.error(
Expand Down
4 changes: 2 additions & 2 deletions server/src/services/content-types/content-types.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ export default ({ strapi }) => ({
const contentTypeUids = Object.keys(contentTypes)
if (contentTypeUids.includes(contentType)) return contentType

const contentTypdUid = contentTypeUids.find(uid => {
const contentTypeUid = contentTypeUids.find(uid => {
return contentTypes[uid].modelName === contentType
})

return contentTypdUid
return contentTypeUid
},

/**
Expand Down
2 changes: 1 addition & 1 deletion server/src/services/meilisearch/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export default ({ strapi }) => {
contentType,
})

// If the entry does not answers the predicate
// If the entry does not answer the predicate
if (!isValid) return filteredEntries

const syncFilteredEntries = await filteredEntries
Expand Down
4 changes: 2 additions & 2 deletions server/src/services/meilisearch/connector.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import Meilisearch from './client'
* Add one entry from a contentType to its index in Meilisearch.
*
* @param {object} options
* @param {object} options.config - Configuration utililites.
* @param {object} options.adapter - Adapter utililites.
* @param {object} options.config - Configuration utilities.
* @param {object} options.adapter - Adapter utilities.
* @param {string} options.contentType - ContentType name.
* @param {object[] | object} options.entries - Entries to sanitize.
* @returns {Promise<object[] | object>} - Sanitized entries.
Expand Down

0 comments on commit be6ff95

Please sign in to comment.