Merge pull request #173 from devhindo/lint

Update GitHub Actions workflows to use setup-go@v5 and golangci-lint-action@v6; refactor error formatting and import statements

.github/workflows/build-and-release.yml

@@ -19,7 +19,7 @@ jobs:
       with:
         fetch-depth: 1
     - name: Setup Go
-      uses: actions/setup-go@v4
+      uses: actions/setup-go@v5
       with:
         go-version: 1.23
     - run: GOPROXY=direct GOSUMDB=off GO111MODULE=on go build .

.github/workflows/ci.yml

@@ -13,15 +13,15 @@ jobs:
     name: Check & Review code
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/setup-go@v4
+      - uses: actions/setup-go@v5
         with:
           go-version: 1.23
       - uses: actions/checkout@master
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v6
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
-          version: v1.54
+          version: v1.62
 
           # Optional: working directory, useful for monorepos
           # working-directory: somedir
@@ -40,7 +40,7 @@ jobs:
         with:
           fetch-depth: 1
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: 1.23
       - run: GOPROXY=https://proxy.golang.org,direct GOSUMDB=off GO111MODULE=on go install github.com/kisielk/errcheck@latest; /home/runner/go/bin/errcheck -tags draft ./...
@@ -53,7 +53,7 @@ jobs:
         with:
           fetch-depth: 1
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: 1.23
       - run: |
@@ -75,13 +75,13 @@ jobs:
         with:
           fetch-depth: 1
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: 1.23
-      - uses: dominikh/staticcheck-action@v1.2.0
+      - uses: dominikh/staticcheck-action@v1.3.0
         with:
+          version: "latest"
           install-go: false
-          version: "2022.1"
   vet:
     name: Vet
     runs-on: ubuntu-latest
@@ -91,7 +91,7 @@ jobs:
         with:
           fetch-depth: 1
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: 1.23
       - run: GOPROXY=https://proxy.golang.org,direct GOSUMDB=off GO111MODULE=on go vet -tags draft ./...
@@ -121,7 +121,7 @@ jobs:
        with:
         fetch-depth: 1
      - name: Setup Go
-       uses: actions/setup-go@v4
+       uses: actions/setup-go@v5
        with:
         go-version: 1.23
      - name: Create cluster using KinD

.github/workflows/component-generator.yml

@@ -16,7 +16,7 @@ jobs:
           token: ${{ secrets.GH_ACCESS_TOKEN }}
           ref: "master"
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: 1.23
       - name: Run adapter to create components

.github/workflows/error-ref-publisher.yml

@@ -19,7 +19,7 @@ jobs:
           ref: 'master'
 
       - name: Setup Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: 1.23
 

cilium/cilium.go

@@ -28,8 +28,8 @@ import (
 	"github.com/layer5io/meshkit/errors"
 	"github.com/layer5io/meshkit/logger"
 	"github.com/layer5io/meshkit/models"
-	"github.com/layer5io/meshkit/utils"
 	"github.com/layer5io/meshkit/models/oam/core/v1alpha1"
+	"github.com/layer5io/meshkit/utils"
 	"github.com/layer5io/meshkit/utils/events"
 	"gopkg.in/yaml.v2"
 )

cilium/oam.go

@@ -151,7 +151,7 @@ func mergeErrors(errs []error) error {
 		errMsgs = append(errMsgs, err.Error())
 	}
 
-	return fmt.Errorf(strings.Join(errMsgs, "\n"))
+	return fmt.Errorf("%s", strings.Join(errMsgs, "\n"))
 }
 
 func mergeMsgs(strs []string) string {

cilium/oam/register.go

@@ -15,19 +15,22 @@ var (
 	//WorkloadPath will be used by both static and component generation
 	WorkloadPath        = filepath.Join(basePath, "templates", "oam", "workloads")
 	MeshmodelComponents = filepath.Join(basePath, "templates", "meshmodel", "components")
-	traitPath           = filepath.Join(basePath, "templates", "oam", "traits")
-	basePath, _         = os.Getwd()
+	//	traitPath           = filepath.Join(basePath, "templates", "oam", "traits") <= unused variable
+	basePath, _ = os.Getwd()
 )
 
 // AvailableVersions denote the component versions available statically
 var AvailableVersions = map[string]bool{}
 var availableVersionGlobalMutex sync.Mutex
 
+// unused type
+/*
 type schemaDefinitionPathSet struct {
 	oamDefinitionPath string
 	jsonSchemaPath    string
 	name              string
 }
+*/
 
 type meshmodelDefinitionPathSet struct {
 	meshmodelDefinitionPath string
@@ -77,4 +80,4 @@ func loadMeshmodelComponents(basepath string) ([]meshmodelDefinitionPathSet, err
 	}
 
 	return res, nil
-}
+}

main.go

@@ -53,7 +53,7 @@ func init() {
 func main() {
 	// Initialize Logger instance
 	log, err := logger.New(serviceName, logger.Options{
-		Format:     logger.SyslogLogFormat,
+		Format: logger.SyslogLogFormat,
 	})
 	if err != nil {
 		fmt.Println(err)
@@ -120,10 +120,6 @@ func main() {
 	}
 }
 
-func isDebug() bool {
-	return os.Getenv("DEBUG") == "true"
-}
-
 func mesheryServerAddress() string {
 	meshReg := os.Getenv("MESHERY_SERVER")