Introduce schemas for map key constraints #1161
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some schemas to help constrain the keysets of
:map
schemas. Instead of[:and [:map ..] [:fn <OPAQUE>]]
, you now write[:and [:map ...] [:xor ..] [:iff ..] ...]
.The next step is to improve the generators for these schemas. The basic strategy to generate
[:and S T]
will be to generateS
but propagateT
as a hint to theS
generator. Most of the work will be to canonicalizeT
by expanding into disjunctive normal form.Humanization comes with the usual caveats of not being able to represent the difference between a conjunction or disjunction of errors, so some of the humanizers are a little strange. I'm not sure if this can be fixed without a breaking change to the humanization representation.
There are more general abstractions here (like the idea of simplifying a schema) but we can build towards that later. I have sketches of using such abstractions to compile optimal validators and generators. For now, concentrating on map keyset constraints is helping move this work along.
Note: the
:max-tries
change is to fix an unrelated flaky test: