Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support psr/container:^2.0 #55

Open
wants to merge 1 commit into
base: 2.16.x
Choose a base branch
from

Conversation

pascalheidmann
Copy link

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Adding support for psr/container:^2.0 in composer.json (its basically the same as 1.0 but with return types)

Signed-off-by: pascal.heidmann <[email protected]>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to CI, psr/container:^2 never got installed while testing this?

@Ocramius Ocramius added the Enhancement New feature or request label Nov 6, 2023
@Ocramius Ocramius added this to the 2.16.0 milestone Nov 6, 2023
@Ocramius
Copy link
Member

Ocramius commented Nov 6, 2023

Same as #23 (review) BTW

@pascalheidmann
Copy link
Author

@Ocramius yeah saw it only afterwards.. Basically wont work until servicemanager 4 will be released? Are you the maintainer of that package too or is it up to @boesing?

@gsteel gsteel removed this from the 2.16.0 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants