-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amazon S3 Bucket (Independent Publisher) - Fix for issue #3702 #3731
base: dev
Are you sure you want to change the base?
Conversation
…e the file correctly in S3 - Fixed: Signing issue of files that contains `(`, `)`, `[`, `]`, `{`, `}`, or `#` characters in the object key. - Logging improved
- `content-type` added as parameter to `Put Object`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear Partner
I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.
[[certify-connector]] |
Any word on when this code will be merged? Thanks! |
@skjones91199 they merge must be completed by the Repo owners. Users does not have permission to complete the merge. We have to wait 😏 |
@megel - once merged, we can do a pac update to update the connector in any tenant we are using it in? |
Hello @megel, The code will be merged once the connector deployed to all the regions. |
When complete, all tenants should have this change available? |
Hello @skjones91199, This connector is in the deployment stage and will be rolled out to all regions in the next 3–4 weeks. Once deployment is complete, we will merge the code. |
Thank you! Forgive my ignorance, but will this be available in all tenants once the deployment is complete? We won't have to do anything on our end to get the changes? |
Changes
Content-Type
of the object as a parameter forPut Object
.(
,)
,{
,}
,[
,]
, and#
in the object key.Test-Screenshots
Put Object
List Objects
Get Object
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: