WIP - [Mouse Without Borders] - refactoring "Common" classes (Part 3) - #35155

[mikeclayton]

Summary of the Pull Request

Part 3 of a slow-running refactor of the giant "Common" class in Mouse Without Borders into individual classes with tighter private scope.

• Extract the "Common" code from Common.MachineStuff.cs into a separate MachineInf.cs, MyRectangle.cs and MachineStuff.cs
• Extract the "Common" code from Common.DragDrop.cs into a separate static class in DragDrop.cs
• Update references to the types in the new locations
• Update unit test to verify functionality has only changed in an expected way

PR Checklist

• Partially addresses [Mouse Without Borders] - refactoring "Common" classes #35155
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Run manual tests from Test Checklist Template:

• Install PowerToys on two PCs in the same local network:

  • Verify that PowerToys is properly installed on both PCs.

• Setup Connection:

  • Open MWB's settings on the first PC and click the "New Key" button. Verify that a new security key is generated.
  • Copy the generated security key and paste it in the corresponding input field in the settings of MWB on the second PC. Also enter the name of the first PC in the required field.
  • Press "Connect" and verify that the machine layout now includes two PC tiles, each displaying their respective PC names.

• Verify Connection Status:

  • Ensure that the border of the remote PC turns green, indicating a successful connection.
  • Enter an incorrect security key and verify that the border of the remote PC turns red, indicating a failed connection.

• Test Remote Mouse/Keyboard Control:

  • With the PCs connected, test the mouse/keyboard control from one PC to another. Verify that the mouse/keyboard inputs are correctly registered on the other PC.
  • Test remote mouse/keyboard control across all four PCs, if available. Verify that inputs are correctly registered on each connected PC when the mouse is active there.
    • unable to test - only 2 machines available

• Test Remote Control with Elevated Apps:

  • note - the main PowerToys.exe must be running as a non-admin for these tests
  • Open an elevated app on one of the PCs. Verify that without "Use Service" enabled, PowerToys does not control the elevated app.
  • Enable "Use Service" in MWB's settings (need to run PowerToys.exe as admin to enable "Use Service", then restart PowerToys.exe as non-admin). Verify that PowerToys can now control the elevated app remotely. Verify that MWB processes are running as LocalSystem, while the MWB helper process is running non-elevated.
  • Toggle "Use Service" again, verify that each time you do that, the MWB processes are restarted.
  • Run PowerToys elevated on one of the machines, verify that you can control elevated apps remotely now on that machine.

• Test Module Enable Status:

  • For all combinations of "Use Service"/"Run PowerToys as admin", try enabling/disabling MWB module and verify that it's indeed being toggled using task manager.

• Test Disconnection/Reconnection:

  • Disconnect one of the PCs from network. Verify that the machine layout updates to reflect the disconnection.
  • Do the same, but now by exiting PowerToys.
  • Start PowerToys again, verify that the PCs are reconnected.

• Test Various Local Network Conditions:

  • Test MWB performance under various network conditions (e.g., low bandwidth, high latency). Verify that the tool maintains a stable connection and functions correctly.

• Clipboard Sharing:

  • Copy some text on one PC and verify that the same text can be pasted on another PC.
  • Use the screenshot key and Win+Shift+S to take a screenshot on one PC and verify that the screenshot can be pasted on another PC.
  • Copy a file in Windows Explorer and verify that the file can be pasted on another PC. Make sure the file size is below 100MB.
  • Try to copy multiple files and directories and verify that it's not possible (only the first selected file is being copied).

• Drag and Drop:

  • Drag a file from Windows Explorer on one PC, cross the screen border onto another PC, and release it there. Verify that the file is copied to the other PC. Make sure the file size is below 100MB.
  • While dragging the file, verify that a corresponding icon is displayed under the mouse cursor.
  • Without moving the mouse from one PC to the target PC, press CTRL+ALT+F1/2/3/4 hotkey to switch to the target PC directly and verify that file sharing/dropping is not working.

• Lock and Unlock with "Use Service" Enabled:

  • Enable "Use Service" in MWB's settings.
  • Lock a remote PC using Win+L, move the mouse to it remotely, and try to unlock it. Verify that you can unlock the remote PC.
  • Disable "Use Service" in MWB's settings, lock the remote PC, move the mouse to it remotely, and try to unlock it. Verify that you can't unlock the remote PC.

• Test Settings:

  • Change the rest of available settings on MWB page and verify that each setting works as described.

Group Policy Tests

• Install *.admx / *.adml and check settings behave as expected
  • I'll expand the list of settings here when I get this far :-)

[htcfreek]

@mikeclayton
Please also test that group policies still work.

[mikeclayton]

@mikeclayton Please also test that group policies still work.

Sure thing. I'm on a standalone laptop so I'm not sure how to configure the policies though - is there a manual test guide anywhere for how to do it?

[htcfreek]

@mikeclayton Please also test that group policies still work.

Sure thing. I'm on a standalone laptop so I'm not sure how to configure the policies though - is there a manual test guide anywhere for how to do it?

Not a guide. But you can copy the admx file and adml file into %windir%\PolicyDefinitions. Then you can use gpedit.msc for configuration. (Requires Pro or Enterprise Edition.)

Alternatively you can look at our end user documentation and set the Registry values manually in [HKLM|HKCU\Software\Policies\PowerToys.

[mikeclayton]

Cheers.

I've got Windows 11 Pro so I'll give that a go.