Adding Lat_Rd_Mem support in LMBENCH #420
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangpanMS
reviewed
Jan 19, 2025
| @@ -238,7 +238,7 @@ private Task BuildSourceCodeAsync(EventContext telemetryContext, CancellationTok | |||
| }); | |||
| } | |||
|
|
|||
| private void CaptureMetrics(IProcessProxy process, MetricsParser metricsParser, EventContext telemetryContext) | |||
| private void CaptureMetrics(IProcessProxy process, MetricsParser metricsParser, EventContext telemetryContext, string scenario) | |||
There was a problem hiding this comment.
telemetryContext at last parameter
| @@ -326,7 +326,7 @@ private Task ExecuteWorkloadAsync(EventContext telemetryContext, CancellationTok | |||
| // The use of the original telemetry context created at the top | |||
| // is purposeful. | |||
| LMbenchMetricsParser lmbenchMetricsParser = new LMbenchMetricsParser(process.StandardOutput.ToString()); | |||
| this.CaptureMetrics(process, lmbenchMetricsParser, relatedContext); | |||
| this.CaptureMetrics(process, lmbenchMetricsParser, relatedContext, "Memory Benchmark"); | |||
There was a problem hiding this comment.
nit:Avoid spaces as much as we could, use an underscore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.