Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Node20 build configurations #20819

Merged
merged 31 commits into from
Feb 4, 2025
Merged

Conversation

merlynomsft
Copy link
Contributor

@merlynomsft merlynomsft commented Jan 31, 2025

Merge Node20 configurations to master by setting mergeToBase: true, and remove respective configs from make-options. As the change is mechanical only, versions in base tasks are not bumped, and will not be included in courtesy push, which checks the package version.

The few tasks which have multiple build configs: PipAuthenticateV1, CargoAuthenticateV0, NpmAuthenticateV0, CondaAuthenticateV0, NuGetAuthenticateV1, MavenAuthenticateV0, TwineAuthenticateV1 are correctly handled.

Note: This PR is too large to be viewed using the "Files changed" tab. Use a local diff tool to view the entire change. Github Desktop is sutable (Select the PR from View -> Branches list, and use Compare Branch to view the commits)

Task name: N/A

Description: see above

Documentation changes required: (Y/N) Y - document mergeToBase process - not in this PR

Added unit tests: (Y/N) N

Attached related issue: (Y/N) AB#2121133

Checklist:

  • [ n/a ] Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@merlynomsft merlynomsft changed the title Users/merlynop/node20merge 2 Merge Node20 build configurations Jan 31, 2025
@merlynomsft merlynomsft force-pushed the users/merlynop/node20merge-2 branch from 0cd741e to 8f496b8 Compare January 31, 2025 02:38
@merlynomsft merlynomsft force-pushed the users/merlynop/node20merge-2 branch 2 times, most recently from 27cfa19 to 70226f0 Compare January 31, 2025 06:52
Copy link

Azure Pipelines failed to run 3 pipeline(s).

1 similar comment
Copy link

Azure Pipelines failed to run 3 pipeline(s).

@merlynomsft merlynomsft merged commit c7f2ab4 into master Feb 4, 2025
11 checks passed
@merlynomsft merlynomsft deleted the users/merlynop/node20merge-2 branch February 4, 2025 04:04
@embetten
Copy link
Contributor

embetten commented Feb 4, 2025

Any reason NpmAuthenticate was not included here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants