Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress C4866 in PayloadDecoder and JsonFormatter's usage of json.hpp #1324

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

mkoscumb
Copy link
Contributor

In C++17 left-to-right evaluation order for operands of operator[] is not guaranteed when the argument's copy constructor is run.
Evalutation order isn't not relied upon here, so I'm disabling warning.

@mkoscumb mkoscumb requested a review from a team as a code owner January 31, 2025 22:23
@lalitb lalitb merged commit 715e5f9 into main Feb 3, 2025
20 of 24 checks passed
@lalitb lalitb deleted the mkoscumb/SuppressC4866AroundJsonHpp branch February 3, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants