-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move json.hpp to a peer folder of other third-party dependencies - Stage 1 #1325
Conversation
…soft/cpp_client_telemetry into mkoscumb/MoveJsonHppStage1
The new json.hpp file seems cannot be loaded into github for review because it has too much lines. Can we download this |
Unfortunately, macOS build is still not working, it's on me. Hopefully, this doesn't break it. We should be able to force-merge it for now. |
@ThomsonTan - It's actually copied from lib/mat directory to new location, so content needn't be reviewed. Because of 3 step process, it can't be moved from lib/mat to root directory. I think downloading from Github can be tracked separately. |
Ok, comparing large files is not very intuitive in the revie UI, but I've verified the file move. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beyond being good dependency hygiene, this will also allow adopters which have their own copy of json.hpp to more easily use that when integrating the 1DS C++ SDK (via include path modification)
This work will be broken down into three PRs.