Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not review] Decouple import batch size from resources in blob file #4788

Open
wants to merge 119 commits into
base: main
Choose a base branch
from

Conversation

gunjitchhhatwal
Copy link

This PR is for testing only.

SergeyGaluzo and others added 30 commits September 27, 2024 08:42
* History separation V0

* Forgotten resource

* replace current by view

* TRUNCATE

* HardDelete

* delete history v0

* missed 64 and removed dead code from SQL query generator

* Removed history from current in merge

* Triggers

* tests and tran

* disable/enable indexes

* rollback hard delete and merge

* rollback delete invisible history

* TRUNCATE -> DELETE

* line

* leftovers

* PK check

* Cosmetic

* WHERE nanes

* Get resources with forced indexes

* Removed redundant where

* Adding feature flag for raw resource dedupping

* Enable invisible history by default

* parameters

* commit

* fixed typo

* 65 + more realistic diff

* adjusted update trigger

* right trigger

* next iteration

* special chars

* Added delete and update

* \r

* Adding script runner

* Added verification

* cosmetic

* HOLDLOCK hint

* removed incorrect comments

* RT

* lock timeout

* 180 and remove empty

* no changes in update resource search params

* blob rewriter tool

* Revert "no changes in update resource search params"

This reverts commit b2e0c38.

* comment

* Generic disable indexes and update search params

* Dummy resources

* fixes

* Dummy records based on surr id

* adjust test to filter dummy rows

* exclude history and current

* Adding PerfTest V-1

* Get asyn wrapper without type string to id function

* tool

* not exists on data copy

* packages back

* Added comments.

* Correct filtered index on resource current

* Added redundant IsHistory=0 to index

* deduping

* Removed dummy records

* pp-p

* history clause

* deduping

* testing parameters

* get resource by type and surr id range with many versions

* skip large databases

* Added calls to fhir

* added conflict

* max retries = 3

* database pings

* examples

* reverse

* start closer

* put logic

* Create

* Move 65 to 84

* Fixes after merge

* Adding RawResources table

* change capture tweeks

* Test fix

* Added MI

* inline insert

* Repeat on updates
@gunjitchhhatwal gunjitchhhatwal requested a review from a team as a code owner January 18, 2025 15:19
{
var start = DateTime.UtcNow;
var sw = Stopwatch.StartNew();
var eol = Encoding.UTF8.GetByteCount(Environment.NewLine);

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
eol
is useless, since its value is never read.
resource.FileId = transactionId;
resource.OffsetInFile = resourceCounter;
var line = resource.ResourceWrapper.RawResource.Data;
var stream = new MemoryStream(Encoding.UTF8.GetBytes(line));

Check warning

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning

Disposable 'MemoryStream' is created but not disposed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants