Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Fixing distance functions for Pinecone, Weaviate and Redis and adding integration tests for score testing for these. #10170

Merged
merged 5 commits into from
Jan 15, 2025
Merged

.Net: Fixing distance functions for Pinecone, Weaviate and Redis and adding integration tests for score testing for these. #10170

merged 5 commits into from
Jan 15, 2025

Conversation

westey-m
Copy link
Contributor

Motivation and Context

#10103

Description

  • Adding integration tests for Pinecone, Weaviate and Redis.
  • Changing EuclideanDistance to EuclideanSquaredDistance for Redis and Pinecone
  • Changing DotProductSimilarity to NegativeDotProduct for Weaviate

Contribution Checklist

@westey-m
Fixing distance functions for Pinecone, Weaviate and Redis and adding…
31e1aab 
… integration tests for score testing for these.
@westey-m westey-m requested a review from a team as a code owner January 13, 2025 16:04
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels Jan 13, 2025
@github-actions github-actions bot changed the title Fixing distance functions for Pinecone, Weaviate and Redis and adding integration tests for score testing for these. .Net: Fixing distance functions for Pinecone, Weaviate and Redis and adding integration tests for score testing for these. Jan 13, 2025
@westey-m westey-m added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@westey-m westey-m enabled auto-merge January 15, 2025 11:24
@westey-m westey-m added this pull request to the merge queue Jan 15, 2025
Merged via the queue into microsoft:main with commit 39934f5 Jan 15, 2025
17 checks passed
@westey-m westey-m deleted the vector-store-score-fixes-pinecone-weaviate-redis branch January 15, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwallace-microsoft markwallace-microsoft markwallace-microsoft approved these changes

@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

Assignees
No one assigned
Labels
kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@westey-m @SergeyMenshykh @markwallace-microsoft