Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable the SingleRootProject tests with check-in tests and fix the getIncludes test failure #13084

Merged
merged 9 commits into from
Dec 31, 2024
Merged

Re-enable the SingleRootProject tests with check-in tests and fix the getIncludes test failure #13084

merged 9 commits into from
Dec 31, 2024

Conversation

sean-mcmanus
Copy link
Contributor

@sean-mcmanus sean-mcmanus commented Dec 27, 2024 •
edited
Loading

  • Re-enable the SingleRootProject tests: A previous change stopped running it for check-in tests, so it was only getting run in the E2E tests.
  • Fixed a test regression from get IntelliSense client by URI #13059

Tests failed with

  1) copilotProviders Tests
       should not provide project context traits when project context isn't available.:
     TypeError: Cannot read properties of undefined (reading 'getClientFor')

@sean-mcmanus sean-mcmanus changed the title Fix getIncludes call with E2E test. Re-enable the SingleRootProject tests with check-in tests and fix the getIncludes test failure Dec 27, 2024
@sean-mcmanus sean-mcmanus marked this pull request as ready for review December 27, 2024 23:31
@sean-mcmanus sean-mcmanus requested a review from a team as a code owner December 27, 2024 23:31
@sean-mcmanus sean-mcmanus merged commit d2626e0 into main Dec 31, 2024
6 checks passed
@sean-mcmanus sean-mcmanus deleted the seanmcm/fixE2ETestGetIncludes branch December 31, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuchungmsft kuchungmsft kuchungmsft approved these changes

@bobbrow bobbrow bobbrow approved these changes

@lukka lukka Awaiting requested review from lukka

@benmcmorran benmcmorran Awaiting requested review from benmcmorran

@fearthecowboy fearthecowboy Awaiting requested review from fearthecowboy

Assignees
No one assigned
Labels
None yet
Projects
cpptools
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sean-mcmanus @bobbrow @kuchungmsft