Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deno compatibility by updating chalk #1111

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kt3k
Copy link

@kt3k kt3k commented Jan 20, 2025

[email protected] uses __proto__ and that makes the package incompatible with Deno.

This PR adds the Deno compatibility to vsce by updating chalk to v4 (Chalk removed the use of __proto__ at v4 chalk/chalk#387 )

You can check the fix by the following steps:

npm run build
deno -A --unstable-detect-cjs vsce

The above commands fail with the below error with the main:

$ deno -A --unstable-detect-cjs vsce
error: Uncaught (in promise) TypeError: chalk_1.default.bgGreen.black is not a function

It shows the correct Usage message with this fix.

$ deno -A --unstable-detect-cjs vsce
Usage: vsce <command>
...

fixes #1110

@kt3k kt3k changed the title chore: update chalk Add Deno compatibility by updating chalk Jan 20, 2025
@kt3k
Copy link
Author

kt3k commented Jan 20, 2025

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Deno compatibility
1 participant