Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dces 670 tests refactoring #1082

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Dces 670 tests refactoring #1082

merged 5 commits into from
Feb 6, 2025

Conversation

vvartakMoJ
Copy link
Contributor

What

Link to story

  1. Use ValidationException instead of ResponseStatusException for consistency with other code.
  2. Use AssertJ fluent assertions
  3. Use given-when-then style names for test methods

Checklist

Before you ask people to review this PR:

  • Tests should be passing: ./gradlew test
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

Additional checks

  • Don’t forget to run the MAAT functional test suite after deploying your changes to the DEV or TEST environments to ensure your changes haven’t broken any of the functional tests.

@vvartakMoJ vvartakMoJ requested a review from a team as a code owner December 30, 2024 16:57
Copy link
Contributor

@dconneely dconneely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously needs MAAT API team to approve as well, but looks pretty comprehensive to me

Copy link
Contributor

@karlbaker02 karlbaker02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vvartakMoJ vvartakMoJ merged commit 5c3bada into main Feb 6, 2025
5 checks passed
@vvartakMoJ vvartakMoJ deleted the DCES-670-tests-refactoring branch February 6, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants