Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crown court calculation outcome payload changes and implementation #291

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

atharmajeed
Copy link
Contributor

@atharmajeed atharmajeed commented Apr 29, 2021

What

Link to story

Maat-API is calculating the case-level crown court outcome. There are some changes to the data structure in how the data will be sent between CDA and maat-API. As a part of this change, updating the maat-API implementation to handle this payload and update the workflow as well as test cases.

Note: Please don't merge this PR yet as this implementation depends on the certain data/flag to be available in CDA/CP.

Checklist

Before you ask people to review this PR:

  • Tests should be passing: ./gradlew test
  • Github should not be reporting conflicts; you should have recently run git rebase master.
  • Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
  • You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@atharmajeed atharmajeed requested a review from a team as a code owner April 29, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant