Skip to content

Commit

Permalink
disable upload-artifact until can get a more satifactory solution
Browse files Browse the repository at this point in the history
  • Loading branch information
nickdavis2001 committed Feb 3, 2025
1 parent 10cde9a commit a99c48b
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 16 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/cypress_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,13 @@ jobs:
npm install .
./cypress/cypress_start.sh
- name: Upload Screenshot Artifact
if: failure()
uses: actions/[email protected]
with:
name: cypress-screenshots
path: cypress/screenshots/
# Note - V 3 of upload-artifact is deprecated but V 4 disallows uploading artifact of the same name. Commented for now but needs rework
#- name: Upload Screenshot Artifact
# if: failure()
# uses: actions/[email protected]
# with:
# name: cypress-screenshots
# path: cypress/screenshots/

- name: Configure AWS Credentials
if: always()
Expand Down
22 changes: 12 additions & 10 deletions .github/workflows/phpunit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,12 @@ jobs:
run: XDEBUG_MODE=coverage php ./vendor/bin/phpunit --coverage-html ./coverage-html --coverage-xml ./coverage-xml
- name: Check coverage
run: php ../scripts/pipeline/php_coverage/check_coverage.php ./coverage-xml/index.xml ${{ matrix.scan.minCoverage }}
- name: Upload Coverage Artifacts
uses: actions/[email protected]
with:
name: coverage-html
path: ${{ matrix.scan.path }}/coverage-html/
# Note - V 3 of upload-artifact is deprecated but V 4 disallows uploading artifact of the same name. Commented for now but needs rework
#- name: Upload Coverage Artifacts
# uses: actions/[email protected]
# with:
# name: coverage-html
# path: ${{ matrix.scan.path }}/coverage-html/
phpunit_all_services:
name: phpunit
runs-on: ubuntu-latest
Expand Down Expand Up @@ -103,8 +104,9 @@ jobs:
run: XDEBUG_MODE=coverage php ./vendor/bin/phpunit --coverage-html ./coverage-html --coverage-xml ./coverage-xml
- name: Check coverage
run: php ../scripts/pipeline/php_coverage/check_coverage.php ./coverage-xml/index.xml ${{ matrix.scan.minCoverage }}
- name: Upload Coverage Artifacts
uses: actions/[email protected]
with:
name: coverage-html
path: ${{ matrix.scan.path }}/coverage-html/
# Note - V 3 of upload-artifact is deprecated but V 4 disallows uploading artifact of the same name. Commented for now but needs rework
#- name: Upload Coverage Artifacts
# uses: actions/[email protected]
# with:
# name: coverage-html
# path: ${{ matrix.scan.path }}/coverage-html/

0 comments on commit a99c48b

Please sign in to comment.