-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2260 from ministryofjustice/LPAL-1333-reenable-ar…
…tifact-upload LPAL-1333 re-enable upload-artifact with overwrite option
- Loading branch information
Showing
5 changed files
with
36 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -104,13 +104,13 @@ jobs: | |
| npm install . | ||
| ./cypress/cypress_start.sh | ||
| # Note - V 3 of upload-artifact is deprecated but V 4 disallows uploading artifact of the same name. Commented for now but needs rework | ||
| #- name: Upload Screenshot Artifact | ||
| # if: failure() | ||
| # uses: actions/[email protected] | ||
| # with: | ||
| # name: cypress-screenshots | ||
| # path: cypress/screenshots/ | ||
| - name: Upload Screenshot Artifact | ||
| if: failure() | ||
| uses: actions/[email protected] | ||
| with: | ||
| name: cypress-screenshots | ||
| path: cypress/screenshots/ | ||
| overwrite: true | ||
|
|
||
| - name: Configure AWS Credentials | ||
| if: always() | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,12 +57,12 @@ jobs: | |
| run: XDEBUG_MODE=coverage php ./vendor/bin/phpunit --coverage-html ./coverage-html --coverage-xml ./coverage-xml | ||
| - name: Check coverage | ||
| run: php ../scripts/pipeline/php_coverage/check_coverage.php ./coverage-xml/index.xml ${{ matrix.scan.minCoverage }} | ||
| # Note - V 3 of upload-artifact is deprecated but V 4 disallows uploading artifact of the same name. Commented for now but needs rework | ||
| #- name: Upload Coverage Artifacts | ||
| # uses: actions/[email protected] | ||
| # with: | ||
| # name: coverage-html | ||
| # path: ${{ matrix.scan.path }}/coverage-html/ | ||
| - name: Upload Coverage Artifacts | ||
| uses: actions/[email protected] | ||
| with: | ||
| name: coverage-html | ||
| path: ${{ matrix.scan.path }}/coverage-html/ | ||
| overwrite: true | ||
| phpunit_all_services: | ||
| name: phpunit | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -104,9 +104,9 @@ jobs: | |
| run: XDEBUG_MODE=coverage php ./vendor/bin/phpunit --coverage-html ./coverage-html --coverage-xml ./coverage-xml | ||
| - name: Check coverage | ||
| run: php ../scripts/pipeline/php_coverage/check_coverage.php ./coverage-xml/index.xml ${{ matrix.scan.minCoverage }} | ||
| # Note - V 3 of upload-artifact is deprecated but V 4 disallows uploading artifact of the same name. Commented for now but needs rework | ||
| #- name: Upload Coverage Artifacts | ||
| # uses: actions/[email protected] | ||
| # with: | ||
| # name: coverage-html | ||
| # path: ${{ matrix.scan.path }}/coverage-html/ | ||
| - name: Upload Coverage Artifacts | ||
| uses: actions/[email protected] | ||
| with: | ||
| name: coverage-html | ||
| path: ${{ matrix.scan.path }}/coverage-html/ | ||
| overwrite: true | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters