Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning on Django 2.0 and newer #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pacu2
Copy link

@Pacu2 Pacu2 commented Oct 4, 2018

Latest Pytest throws deprecation errors straight into the console, after merging this PR there will be one log less.

context kwarg will be deprecated in Django 3.0, and was dropped since Django 2.0

@@ -18,7 +18,7 @@ def __init__(self, verbose_name=None, currency=None, **kwargs):
self.currency = currency
super(MoneyField, self).__init__(verbose_name, **kwargs)

def from_db_value(self, value, expression, connection, context):
def from_db_value(self, value, *args, **kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need *args here?

@maarcingebala maarcingebala removed their request for review September 3, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants