[Bug Fix] Call uNet segmentation only after video has loaded #1418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear ml5 community,
I'm making a Pull Request(PR). Please see the details below.
A good PR π
β Step 1: Describe your Pull Request π
This is small bug fix for the UNET example. The sketch previously had unstable results as the uNet segmentation function may be called before the video has loaded. The tweak moves the segmentation into a callback function
videoReady
of the video capture function.video = createCapture(VIDEO, videoReady);
This pattern is copied from the BodyPix example (https://editor.p5js.org/ml5/sketches/BodyPix_Webcam).
A great PR ππ
β Step 2: Share a Relevant Example π¦
Please see the live example on p5 editor:
https://editor.p5js.org/mattelim/sketches/dhNEo78-x
The best PR πππ
β Step 3: Screenshots or Relevant Documentation πΌ
Previous:
Now: