Merge pull request #105 from mlibrary/LIBSEARCH-926-deploy-browse-as-…

…a-full-service-ui [LIBSEARCH-926] Deploy Browse as a full service (UI)
mlibrary · Feb 12, 2024 · 7dcdc59 · 7dcdc59
2 parents e175462 + a17c469
commit 7dcdc59
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 44 deletions.
diff --git a/config/search_dropdown.yml b/config/search_dropdown.yml
@@ -32,7 +32,7 @@
   - :label: ISBN/ISSN/OCLC/etc
     :value: isn
     :tip: Search by ISSN (8-digit code), ISBN (13 or 10-digit code), or OCLC number (e.g., 0040-781X; 0747581088; 921446069).
-- :label: Browse by [BETA]
+- :label: Browse by
   :tip: Browse Tip
   :options:
   - :label: Browse by call number (LC and Dewey)

diff --git a/lib/models/author_list.rb b/lib/models/author_list.rb
@@ -16,11 +16,6 @@ def initialize(browse_list:)
     @browse_list = browse_list
   end
 
-  def feedback_url
-    # Author Browse specific url
-    "https://umich.qualtrics.com/jfe/form/SV_43jm8oGIRVLEBbo"
-  end
-
   def name
     "author"
   end

diff --git a/lib/models/browse_list_presenter.rb b/lib/models/browse_list_presenter.rb
@@ -53,10 +53,6 @@ def doc_title
     raise NotImplementedError, "#{self.class} should have implemented..."
   end
 
-  def feedback_url
-    "https://umich.qualtrics.com/jfe/form/SV_bCwYIKueEXs8wBf"
-  end
-
   private
 
   def nav_url(params)

diff --git a/lib/models/subject_list.rb b/lib/models/subject_list.rb
@@ -16,11 +16,6 @@ def initialize(browse_list:)
     @browse_list = browse_list
   end
 
-  def feedback_url
-    # Subject Browse specific url
-    "https://umich.qualtrics.com/jfe/form/SV_brwYt0B1fSx0zFI"
-  end
-
   def name
     "subject"
   end

diff --git a/spec/models/author_list_spec.rb b/spec/models/author_list_spec.rb
@@ -12,13 +12,6 @@
     end
   end
 
-  context "feedback_url" do
-    it "has a different url than the default form" do
-      expect(subject.feedback_url.class).to eq(String)
-      expect(subject.feedback_url).not_to eq(BrowseListPresenter.new(browse_list: nil).feedback_url)
-    end
-  end
-
   context "match_text" do
     it "returns appropriate text for no matches" do
       allow(@browse_list).to receive(:num_matches).and_return(0)

diff --git a/spec/models/callnumber_list_spec.rb b/spec/models/callnumber_list_spec.rb
@@ -12,13 +12,6 @@
     end
   end
 
-  context "feedback_url" do
-    it "has the default form url" do
-      expect(subject.feedback_url.class).to eq(String)
-      expect(subject.feedback_url).to eq(BrowseListPresenter.new(browse_list: nil).feedback_url)
-    end
-  end
-
   context "match_text" do
     it "returns appropriate text for no matches" do
       allow(@browse_list).to receive(:num_matches).and_return(0)

diff --git a/spec/models/subject_list_spec.rb b/spec/models/subject_list_spec.rb
@@ -12,13 +12,6 @@
     end
   end
 
-  context "feedback_url" do
-    it "has a different url than the default form" do
-      expect(subject.feedback_url.class).to eq(String)
-      expect(subject.feedback_url).not_to eq(BrowseListPresenter.new(browse_list: nil).feedback_url)
-    end
-  end
-
   context "help_text" do
     it "returns appropriate help text for browsing by subject" do
       expect(subject.help_text.class).to eq(String)

diff --git a/views/layout.erb b/views/layout.erb
@@ -78,14 +78,6 @@
     <%= erb :'layout/search_box', locals: { list: list } %>
     <%= erb :'layout/datastore_navigation' %>
     <main class="viewport-container">
-      <%
-        url_params = request.params.map {|key, value| key} 
-        if !url_params.include? 'direction'
-      %>
-        <m-callout dismissable icon>
-          <p><span class="strong">Browse by <%= list.name %> beta:</span> We're testing a new feature to browse the catalog by <%= list.name %>. Let us know what you think at our <%= erb :'components/external_link', locals: { url: list.feedback_url, text: 'feedback form' } %>.</p>
-        </m-callout>
-      <% end %>
       <h1 id="maincontent" tabindex="-1">
         <%= list.title %>
       </h1>