Skip to content

Commit

Permalink
Adding isbn, issn, and oclc fields.
Browse files Browse the repository at this point in the history
  • Loading branch information
erinesullivan committed Oct 29, 2024
1 parent b1eaf3e commit 8273f58
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 0 deletions.
15 changes: 15 additions & 0 deletions lib/models/carousel_list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,18 @@ def call_number
@browse_doc["callnumber"]&.strip
end

def isbn
@catalog_doc["isbn"]&.first&.strip
end

def issn
@catalog_doc["issn"]&.first&.strip
end

def oclc
@catalog_doc["oclc"]&.first&.strip
end

def mms_id
@browse_doc["bib_id"]
end
Expand All @@ -52,6 +64,9 @@ def to_h
author: author,
date: date,
call_number: call_number,
isbn: isbn,
issn: issn,
oclc: oclc,
url: url
}
end
Expand Down
12 changes: 12 additions & 0 deletions spec/models/carousel_list_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,15 @@ def body(file_name)
it "has a call_number" do
expect(subject.call_number).to eq("Z 253 .U6 1963")
end
it "has an isbn" do
expect(subject.isbn).to eq(nil)
end
it "has an issn" do
expect(subject.issn).to eq(nil)
end
it "has an oclc" do
expect(subject.oclc).to eq("2497305")
end
it "has an mms_id" do
expect(subject.mms_id).to eq("990011613060106381")
end
Expand All @@ -49,6 +58,9 @@ def body(file_name)
author: "United States. Government Printing Office",
call_number: "Z 253 .U6 1963",
date: "1950",
isbn: nil,
issn: nil,
oclc: "2497305",
title: "Theory and practice of composition.",
url: "#{S.search_url}/catalog/record/990011613060106381"

Expand Down

0 comments on commit 8273f58

Please sign in to comment.