removes author and subject feature gates

README.md

@@ -30,5 +30,3 @@ If you are working on features, set up a gate so that the feature can be turned
 In this project we create an environment variable for the feature. If it is true the feature is enabled. If it is false then it is turned off. 
 
 Current Features:
-* `AUTHOR_ON='true'` for enabling Browse By Author
-* `SUBJECT_ON='true'` for enabling Browse By Subject

catalog-browse.rb

@@ -22,31 +22,28 @@
   config.solr_url = ENV.fetch("BIBLIO_SOLR")
 end
 
-if ENV.fetch("SUBJECT_ON") == "true"
-  get "/subject" do
-    subject = StringCleaner.clean_browse_string(params[:query])
-    reference_id = params[:reference_id] || subject
-    begin
-      list = SubjectList.for(direction: params[:direction], reference_id: reference_id, num_rows_to_display: 20, original_reference: subject, banner_reference: params[:banner_reference])
-    rescue => e
-      logger.error(e.message)
-      list = SubjectList::Error.new(reference_id)
-    end
-    erb :subject, locals: {list: list}
+get "/subject" do
+  subject = StringCleaner.clean_browse_string(params[:query])
+  reference_id = params[:reference_id] || subject
+  begin
+    list = SubjectList.for(direction: params[:direction], reference_id: reference_id, num_rows_to_display: 20, original_reference: subject, banner_reference: params[:banner_reference])
+  rescue => e
+    logger.error(e.message)
+    list = SubjectList::Error.new(reference_id)
   end
+  erb :subject, locals: {list: list}
 end
-if ENV.fetch("AUTHOR_ON") == "true"
-  get "/author" do
-    author = StringCleaner.clean_browse_string(params[:query])
-    reference_id = params[:reference_id] || author
-    begin
-      list = AuthorList.for(direction: params[:direction], reference_id: reference_id, num_rows_to_display: 20, original_reference: author, banner_reference: params[:banner_reference])
-    rescue => e
-      logger.error(e.message)
-      list = AuthorList::Error.new(reference_id)
-    end
-    erb :authors, locals: {list: list}
+
+get "/author" do
+  author = StringCleaner.clean_browse_string(params[:query])
+  reference_id = params[:reference_id] || author
+  begin
+    list = AuthorList.for(direction: params[:direction], reference_id: reference_id, num_rows_to_display: 20, original_reference: author, banner_reference: params[:banner_reference])
+  rescue => e
+    logger.error(e.message)
+    list = AuthorList::Error.new(reference_id)
   end
+  erb :authors, locals: {list: list}
 end
 get "/callnumber" do
   callnumber = params[:query]

env.example

@@ -2,5 +2,3 @@ BIBLIO_SOLR='http://biblio-server/solr'
 CATALOG_SOLR='http://catalog-solr-server/solr'
 CALLNUMBERS_CORE='callnumbers'
 AUTHORS_CORE='authors'
-AUTHOR_ON='true'
-SUBJECT_ON='true'

views/layout/search_box.erb

@@ -1,12 +1,6 @@
 <%
   fields = YAML.load_file("./config/search_dropdown.yml")
   active_browse_option = 'browse_by_' + request.path_info[1..-1]
-  if ENV.fetch("SUBJECT_ON") == "false"
-    browse_by = fields.find{|x| x[:label] == "Browse by [BETA]"}
-    browse_by_subject = browse_by[:options].find{|x| x[:label] == "Browse by subject"}
-    browse_by_subject[:label] = "Browse by subject (coming soon)"
-    browse_by_subject[:disabled] = "disabled"
-  end
 %>
 
 <form class="search-box" role="search" method="post" action="<%= ENV.fetch('BASE_URL') %>/search">