First page bug #124
Draft
First page bug #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the first page of results to use a different field for fq and sort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been a problem with callnumber browse where the first page of results only has 2 results preceding the searched for result. This PR fixes that bug.
The problem has been that for the first page of results we need to use a different field for the filter query and the sort than we do have next and previous results. For next and previous we can use the
idfield because it has the full id, so the id will be found in the list. For the first page we only have what string the user submitted, so we need to use either thecallnumberor thetermfield.This doesn't work with
authororsubjectbrowse. Need to do more investigating.