[LIBSEARCH-1032] Test an integration of book covers from Syndetic Solutions in the shelf carousel #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erinesullivan
added
documentation
niquerio
requested changes
Nov 5, 2024
|
Testing ends on the 28th. Merging this in now will expose all defined information. We're not even sure if this will become a feature. For now we're going to keep this as a draft so it's easy to find, and wait until we know more about what we're doing with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Search has access to Syndetic Solutions book cover API until November 28. In order to pull the images, we need access to the record's
isbn,issn, and/oroclcdata. This pull request adds those fields to the carousel API.This pull request fixes LIBSEARCH-1032.
Testing
docker-compose run --rm web bundle exec rspec).