-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website 39 add onsite location details to where for events exhibits page template #313
Merged
SalazarJosh
merged 8 commits into
master
from
WEBSITE-39-Add-onsite-location-details-to-where-for-Events-Exhibits-page-template
Oct 25, 2024
Merged
Website 39 add onsite location details to where for events exhibits page template #313
SalazarJosh
merged 8 commits into
master
from
WEBSITE-39-Add-onsite-location-details-to-where-for-Events-Exhibits-page-template
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eventFormatWhere was only returning room and building fields. We now need room on one line, building, floor, and room number on the next. I'm also now looking up the floorPlan in the event and adding that to the end of the "where" label if it exists.
…n-site event could still have an address so I refactored eventFormatWhere to support that, removed redundancy, etc.
…o added check for isBrief for online events so we don't show link / URL on the event cards
…he same line as the "hybrid" or "online" label.
erinesullivan
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 I see the working links in comparison to the live site. I also love seeing a PR that deletes more code than adding. Great job!
…where-for-Events-Exhibits-page-template
SalazarJosh
deleted the
WEBSITE-39-Add-onsite-location-details-to-where-for-Events-Exhibits-page-template
branch
October 25, 2024 16:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is specific to the "WHERE" for event details on the event template and the event cards as seen on the Today and Upcoming page and the "What’s happening?" section on the homepage.
There are three parts to this enhancement:
How I went about it
The strings are built in
eventFormatWhere
in the event.js utility file. They're built by pushing a series of strings namedlabel
to an object arraywhere
.where
is then mapped in the event template file and thelocality
is extracted and applied as a link if it's present.The floor plans are loaded in the event template file using
useFloorPlan
from use-floor-plan.js.The "View directions" link is generated from
createGoogleMapsURL
if there is a locality in therewhere
object. Both non-library events and library events can have a "View directions" link, but non-library events should always have a "View directions" link.Examples
Here are some current events that we can preview:
For other events, hybrid and online, we don’t have current examples, but I can edit event details before running the logic to see what that looks like:
A hybrid event with a library location:
And the card:
A hybrid event with a library location and event link:
And the card (same as above):
An online event (no library location):
And the card:
Testing