WEBSITE-164 Adjust colors for icons in locationAside to meet minimum acceptable contrast #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added color prop to LayoutWithIcon so we can use more than one color for the icons. Set the colors of each icon to the requested color.
erinesullivan
approved these changes
Nov 12, 2024
SalazarJosh
deleted the
WEBSITE-134-adjust-colors-for-icons-in-locationAside
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Problem: When we completed the accessibility warning remediation for the maize icons, we missed that none of the icons that sit on top of a circle background meet minimum accessible contrast requirements.
The following meet minimum:
Testing
List instructions on how to test the pull request. Some examples: